lkml.org 
[lkml]   [2023]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8.1 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing packets
On Tue, Jul 25, 2023 at 08:10:21PM +0100, Dmitry Safonov wrote:

...

> >
> >> + struct tcp_ao_key *rnext_key;
> >> + struct tcp_ao_info *ao_info;
> >> + u8 maclen;
> >>
> >> + if (WARN_ON_ONCE(!ao_key))
> >> + goto out_ao;
> >> + ao_info = rcu_dereference_check(tp->ao_info,
> >> + lockdep_sock_is_held(&tp->inet_conn.icsk_inet.sk));
> >
> > Checkpatch complains about indentation here.
> >
> > Rather than point out each case in the series,
> > could I ask you to run ./scripts/checkpatch.pl --strict over the patchset?
>
> Yeah, but then it won't fit 80 columns here. As both aren't hard
> requirements I tend to comply with 80 columns more than to indentation.
> In this particular case I'll check if it could be a helper function.
> If it won't make sense to separate it as a helper, I'll just move it to
> the same line than, breaking 80 columns limit.

Thanks, I missed the 80 column thing here.
I'd actually think that what you have is better than an extra long line.
But it's your call.

...

\
 
 \ /
  Last update: 2023-07-25 22:24    [W:0.079 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site