Messages in this thread | | | Date | Tue, 25 Jul 2023 18:49:27 +0000 (UTC) | Subject | Re: [PATCH] arm64: dts: rockchip: Fix regulators and enable SATA on Radxa E25 | From | Jonas Karlman <> |
| |
On 2023-07-25 20:32, Heiko Stuebner wrote: > On Mon, 24 Jul 2023 14:52:16 +0000 (UTC), Jonas Karlman wrote: >> Despite its name, the regulator vcc3v3_pcie30x1 has nothing to do with >> pcie30x1. Instead, it supply power to VBAT1-5 on the M.2 KEY B port as >> seen on page 8 of the schematic [1]. >> >> pcie30x1 is used for the mini PCIe slot, and as seen on page 9 the >> vcc3v3_minipcie regulator is instead related to pcie30x1. >> >> [...] > > Applied, thanks! > > [1/2] arm64: dts: rockchip: Fix PCIe regulators on Radxa E25 > commit: a87852e37f782257ebc57cc44a0d3fbf806471f6 > > [2/2] arm64: dts: rockchip: Enable SATA on Radxa E25 > commit: 2bdfe84fbd57a4ed9fd65a67210442559ce078f0 > > As you can see, I've split them in two. Please check that I didn't > mess anything up. Having an "and" in the commit subject is always a > very strong indicator that a split is probably a good thing ;-)
Thanks, and they look fine. Should probably have split it in two from the beginning, I will try to do better next time :-)
Regards, Jonas
> > > Best regards,
| |