Messages in this thread | | | Date | Mon, 24 Jul 2023 07:26:27 -0700 | Subject | Re: [PATCH v4 11/20] KVM:x86: Save and reload GUEST_SSP to/from SMRAM | From | Sean Christopherson <> |
| |
On Mon, Jul 24, 2023, Weijiang Yang wrote: > > On 7/24/2023 5:13 PM, Chao Gao wrote: > > On Thu, Jul 20, 2023 at 11:03:43PM -0400, Yang Weijiang wrote: > > > Save GUEST_SSP to SMRAM on SMI and reload it on RSM. > > > KVM emulates architectural behavior when guest enters/leaves SMM > > > mode, i.e., save registers to SMRAM at the entry of SMM and reload > > > them at the exit of SMM. Per SDM, GUEST_SSP is defined as one of > > To me, GUEST_SSP is confusing here. From QEMU's perspective, it reads/writes > > the SSP register. People may confuse it with the GUEST_SSP in nVMCS field. > > I prefer to rename it to MSR_KVM_SSP. > > Hmm, looks a bit, I'll change it, thanks!
Please just say "SSP". The SMRAM field has nothing to do with KVM's synthetic MSR.
| |