Messages in this thread | | | Date | Sun, 23 Jul 2023 22:40:27 +0530 | From | Sunil V L <> | Subject | Re: [PATCH -fixes] RISC-V: ACPI: Fix acpi_os_ioremap to return iomem address |
| |
On Sun, Jul 23, 2023 at 05:49:22PM +0100, Conor Dooley wrote: > Hey Sunil, > > On Sun, Jul 23, 2023 at 08:34:34PM +0530, Sunil V L wrote: > > Fix the acpi_os_ioremap() to return iomem address and > > use memory attributes from EFI memory map while remapping. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202307230357.egcTAefj-lkp@intel.com/ > > Fixes: a91a9ffbd3a5 ("RISC-V: Add support to build the ACPI core") > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > Huh, there's quite a lot more going on here than $subject would > suggest... This really seems like it should be a pair of commits, with > a trivial one fixing the lkp reported sparse issue & a second one, with > a more detailed commit message, implementing the memory attributes > stuff. Doing it as an "afterthought" as part of the LKP fix does not seem > at all right to me. > Thanks!, Conor. Yeah, I agree. I had the patch ready to enhance this function and when I saw today bot finding the issue, I just updated to make it fix patch. Let me split to two patches.
> When you split it, I figure you should CC Ard and Alex Ghiti on the > patch adding the EFI attribute stuff. > Sure.
Thanks, Sunil
| |