lkml.org 
[lkml]   [2023]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable
On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:

> + ret = devm_add_action_or_reset(&i2c->dev, rt5665_i2c_disable_regulators,
> + rt5665);
> + if (ret)
> + return ret;
> +
> ret = regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
> rt5665->supplies);
> if (ret != 0) {

This will attempt to disable the regulators if the initial enable fails
which is a bug.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-23 17:12    [W:0.085 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site