Messages in this thread | | | Date | Sat, 22 Jul 2023 21:11:54 +0100 | From | Mark Brown <> | Subject | Re: [PATCH RESEND RESEND] thermal/of: support thermal zones w/o trips subnode |
| |
On Sat, Jul 22, 2023 at 08:25:34PM +0800, Icenowy Zheng wrote: > From: Icenowy Zheng <uwu@icenowy.me> > > Although the current device tree binding of thermal zones require the > trips subnode, the binding in kernel v5.15 does not require it, and many > device trees shipped with the kernel, for example, > allwinner/sun50i-a64.dtsi and mediatek/mt8183-kukui.dtsi in ARM64, still > comply to the old binding and contain no trips subnode. > > Allow the code to successfully register thermal zones w/o trips subnode > for DT binding compatibility now. > > Furtherly, the inconsistency between DTs and bindings should be resolved > by either adding empty trips subnode or dropping the trips subnode > requirement.
This makes sense to me - it allows people to see the reported temperature even if there's no trips defined which seems more helpful than refusing to register.
Reviewed-by: Mark Brown <broonie@kernel.org> [unhandled content-type:application/pgp-signature] | |