Messages in this thread | | | Date | Sat, 22 Jul 2023 17:15:26 +0200 | From | Greg KH <> | Subject | Re: [RESEND PATCH v8 06/10] serial: sc16is7xx: fix regression with GPIO configuration |
| |
On Sat, Jul 22, 2023 at 10:47:24AM -0400, Hugo Villeneuve wrote: > On Fri, 21 Jul 2023 13:24:19 -0600 > Rob Herring <robh+dt@kernel.org> wrote: > > > On Fri, Jul 21, 2023 at 10:19 AM Hugo Villeneuve <hugo@hugovil.com> wrote: > > > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines") > > > and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines") > > > changed the function of the GPIOs pins to act as modem control > > > lines without any possibility of selecting GPIO function. > > > > Requiring a new DT property is not fixing a kernel regression. You > > should be returning the kernel to original behavior and then have a > > new DT property for new behavior. > > Hi Rob, > please read the entire patch history starting from V1 > and you will understand why this course of action was > not selected.
That's not going to happen, sorry, you need to explain it here, in this patch series, why a specific action is being taken over another one, as no one has time to go dig through past history, sorry.
thanks,
greg k-h
| |