Messages in this thread | | | Date | Sat, 22 Jul 2023 11:47:53 +0200 | Subject | Re: [PATCH] dt-bindings: i2c: arb-gpio-challange: convert to DT schema | From | Krzysztof Kozlowski <> |
| |
On 21/07/2023 20:06, Doug Anderson wrote: > Hi, > > On Fri, Jul 21, 2023 at 6:30 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml >> new file mode 100644 >> index 000000000000..17f15490f073 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml >> @@ -0,0 +1,138 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/i2c/i2c-arb-gpio-challenge.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: GPIO-based I2C Arbitration Using a Challenge & Response Mechanism >> + >> +maintainers: >> + - Doug Anderson <dianders@chromium.org> >> + - Peter Rosin <peda@axentia.se> > > While I don't object to Peter Rosin being listed here if he wants it, > I suspect that you added him because he was the author of > "i2c-arb.txt". I guess that file was really only added to try to keep > things common between this GPIO arbitrator and the one that he cares
I added him because he was listed as maintainer of all arbitration bindings (as part of I2C MUX entry in MAINTAINERS).
> about: "nxp,pca9541.txt". Probably he doesn't want to be added here. > > Speaking of "nxp,pca9541.txt", it seems like you need to convert that > before removing "i2c-arb.txt". It still refers to that file even after > your patch, doesn't it?
Indeed, thanks. I will convert it.
> > In any case, other than that, this looks fine. Thanks for doing the conversion! > > Acked-by: Douglas Anderson <dianders@chromium.org>
Best regards, Krzysztof
| |