Messages in this thread | | | Date | Sat, 22 Jul 2023 11:21:59 +0200 | Subject | Re: [PATCH 05/10] dt-bindings: clock: Add Marvell PXA1908 clock bindings | From | Krzysztof Kozlowski <> |
| |
On 21/07/2023 22:37, Duje Mihanović wrote: > Add the dt bindings for Marvell PXA1908 clock controller. >
Squash the patch with bindings change. It has little sense on its own,
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > include/dt-bindings/clock/marvell,pxa1908.h | 93 +++++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 include/dt-bindings/clock/marvell,pxa1908.h > > diff --git a/include/dt-bindings/clock/marvell,pxa1908.h b/include/dt-bindings/clock/marvell,pxa1908.h > new file mode 100644 > index 000000000000..da9c5d499ae4 > --- /dev/null > +++ b/include/dt-bindings/clock/marvell,pxa1908.h > @@ -0,0 +1,93 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */
Dual license. Didn't checkpatch complain?
> +#ifndef __DTS_MARVELL_PXA1908_CLOCK_H > +#define __DTS_MARVELL_PXA1908_CLOCK_H > + > +/* plls */ > +#define PXA1908_CLK_CLK32 0x1 > +#define PXA1908_CLK_VCTCXO 0x2 > +#define PXA1908_CLK_PLL1_624 0x3
IDs are decimal numbers.
> +#define PXA1908_CLK_PLL1_416 0x4 > +#define PXA1908_CLK_PLL1_499 0x5 > +#define PXA1908_CLK_PLL1_832 0x6 > +#define PXA1908_CLK_PLL1_1248 0x7 > +#define PXA1908_CLK_PLL1_D2 0x8
Best regards, Krzysztof
| |