Messages in this thread | | | From | "Ng, Boon Khai" <> | Subject | RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload | Date | Fri, 21 Jul 2023 15:35:44 +0000 |
| |
> -----Original Message----- > From: Shevchenko, Andriy <andriy.shevchenko@intel.com> > Sent: Friday, July 21, 2023 6:18 PM > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>; > David S . Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; Maxime Coquelin <mcoquelin.stm32@gmail.com>; > netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ng, > Boon Khai <boon.khai.ng@intel.com>; Tham, Mun Yew > <mun.yew.tham@intel.com>; Swee, Leong Ching > <leong.ching.swee@intel.com>; G Thomas, Rohan > <rohan.g.thomas@intel.com> > Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt- > bindings: net: snps,dwmac: Add description for rx-vlan-offload > > On Fri, Jul 21, 2023 at 02:26:16PM +0800, Boon@ecsmtp.png.intel.com wrote: > > From: Boon Khai Ng <boon.khai.ng@intel.com> > > > > This patch is to add the dts setting for the MAC controller on > > synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware > > accelerated VLAN stripping. Once the hardware accelerated VLAN > > stripping is turn on, the VLAN tag will be stripped by the 10G > > Ethernet MAC. > > ... > > > Reviewed-by: Shevchenko Andriy <andriy.shevchenko@linux.intel.com> > > This is wrong: > - I never reviewed DT bindings in all your series. > - My name for the patches is also wrong. > > P.S. What I mentioned in the internal mail is that you can add my tag to > the code, and not to the DT. Sorry, I probably hadn't been clear. >
My bad, sorry for interpreting the meaning wrongly, I will remove all the "Reviewed-by" stamp from all the DT patches on the next update.
However I copied the Reviewed-by: from the previous email, your name Shouldn't be wrong.
> -- > With Best Regards, > Andy Shevchenko >
| |