lkml.org 
[lkml]   [2023]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/7] x86/amd_nb: Add AMD Family 19h Models(80h-80fh) and (90h-9fh) PCI IDs
From
On 7/20/2023 8:54 AM, Muralidhara M K wrote:
> From: Muralidhara M K <muralidhara.mk@amd.com>
>
> Add new Root, Device 18h Function 3, and Function 4 PCI IDS
> for x86 AMD family 19h, Models 80h-80fh and 90h-9fh.
>

$SUBJECT and commit message reference Family/Models, but the patch uses
the code name MI300.

I suggest using MI300 in the $SUBJECT. And highlight in the message that
both groups of MI300 use the same IDs. You can clarify that Models
80h-8Fh are MI300C and 90h-9Fh are MI300A.

Thanks,
Yazen

\
 
 \ /
  Last update: 2023-07-21 16:45    [W:0.178 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site