Messages in this thread | | | Date | Fri, 21 Jul 2023 15:37:00 +0200 | From | Markus Schneider-Pargmann <> | Subject | Re: [PATCH v5 12/12] can: m_can: Implement transmit submission coalescing |
| |
Hi Simon,
On Thu, Jul 20, 2023 at 04:58:49PM +0100, Simon Horman wrote: > On Tue, Jul 18, 2023 at 09:57:08AM +0200, Markus Schneider-Pargmann wrote: > > m_can supports submitting multiple transmits with one register write. > > This is an interesting option to reduce the number of SPI transfers for > > peripheral chips. > > > > The m_can_tx_op is extended with a bool that signals if it is the last > > transmission and the submit should be executed immediately. > > > > The worker then writes the skb to the FIFO and submits it only if the > > submit bool is set. If it isn't set, the worker will write the next skb > > which is waiting in the workqueue to the FIFO, etc. > > > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
Thank you for your reviews!
Best, Markus
| |