lkml.org 
[lkml]   [2023]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml
From
On 21/07/2023 13:58, Andrea Collamati wrote:
> Hi Krzysztof,
>
> On 7/21/23 10:21, Krzysztof Kozlowski wrote:
>>> Add documentation for MCP4728
>>>
>>> Signed-off-by: Andrea Collamati <andrea.collamati@gmail.com>
>>> ---
>>> .../bindings/iio/dac/microchip,mcp4728.yaml | 48 +++++++++++++++++++
>>> 1 file changed, 48 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>>> new file mode 100644
>>> index 000000000000..6fd9be076245
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>>> @@ -0,0 +1,48 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Microchip MCP4728 DAC
>>> +
>>> +description:
>>> + MCP4728 is a quad channel, 12-bit voltage output
>>> + Digital-to-Analog Converter with non-volatile
>>> + memory and I2C compatible Serial Interface.
>>> + https://www.microchip.com/en-us/product/mcp4728
>>> +
>>> +maintainers:
>>> + - Andrea Collamati <andrea.collamati@gmail.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - microchip,mcp4728
>> This is a friendly reminder during the review process.
>
> Sorry but I didn't understand all your requests:
>
> - I changed in the title mcp4728 with MCP4728
>
> - I added description
>
> but I don't know which blank line or whitespaces should be removed.
>
> Can you tell me please?

You forgot to add blank line. Open example-schema and compare.

Also, you had white-space errors. Editors should show it to you. Git
maybe as well.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-07-21 14:08    [W:0.075 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site