lkml.org 
[lkml]   [2023]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY
From

On 7/17/2023 12:55 PM, Krzysztof Kozlowski wrote:
> On 14/07/2023 07:08, Mrinmay Sarkar wrote:
>> Add devicetree YAML binding for Qualcomm QMP PCIe PHY
>> for SA8775p platform.
>>
>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com>
>> ---
>> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> index a0407fc..ca55ed9 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> @@ -16,6 +16,8 @@ description:
>> properties:
>> compatible:
>> enum:
>> + - qcom,sa8775p-qmp-gen4x2-pcie-phy
>> + - qcom,sa8775p-qmp-gen4x4-pcie-phy
>> - qcom,sc8280xp-qmp-gen3x1-pcie-phy
>> - qcom,sc8280xp-qmp-gen3x2-pcie-phy
>> - qcom,sc8280xp-qmp-gen3x4-pcie-phy
>> @@ -30,7 +32,7 @@ properties:
>>
>> clocks:
>> minItems: 5
>> - maxItems: 6
>> + maxItems: 7
>>
>> clock-names:
>> minItems: 5
>> @@ -41,6 +43,7 @@ properties:
>> - const: rchng
>> - const: pipe
>> - const: pipediv2
>> + - const: phy_aux
>>
>> power-domains:
>> maxItems: 1
>> @@ -141,6 +144,20 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> + - qcom,sa8775p-qmp-gen4x2-pcie-phy
>> + - qcom,sa8775p-qmp-gen4x4-pcie-phy
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 7
>> + clock-names:
>> + minItems: 7
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
> This probably works but is not obvious and easy to read. You have here
> if:then:else: block, so else applies to your variant. Change all these
> if clauses for clocks into separate clauses per matching variant
> (if:then: ... if:then:... if:then:...)
>
> Best regards,
> Krzysztof

My Bad here, This patch already applied we will take care this in next
patch set.

Thanks,
Mrinmay

>

\
 
 \ /
  Last update: 2023-07-21 13:10    [W:0.173 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site