Messages in this thread | | | Date | Fri, 21 Jul 2023 20:05:28 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD indexes |
| |
On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote: > On 7/21/2023 11:14 AM, Pavan Kondeti wrote: > > On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote: > > > diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h [..] > > > + > > > +#endif > > > -- > > I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still > > coming from qcom-rpmpd.h. Which means Socs with RPMh also need to > > include the older header for these definitions along with this newly > > created header. something to improve for the clarity sake? > Agreed. I think we can move these to the new header so that the new SoC with > RPMH can completely > move to rpmhpd.h.
Sounds very reasonable, please do that in a follow up patch. I'm picking this as is.
Thanks, Bjorn
| |