lkml.org 
[lkml]   [2023]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] regmap: Remove dynamic allocation warnings for rbtree and maple
From
On 7/21/23 09:31, Mark Brown wrote:
> Thanks to Dan and Guenter's very prompt updates of the rbtree and maple
> caches to support GPF_ATOMIC allocations and since the update shook out
> a bunch of users at least some of whom have been suitably careful about
> ensuring that the cache is prepoulated so there are no dynamic
> allocations after init let's revert the warnings.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/base/regmap/regmap.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index 6c637b18d6b0..8b37451fa931 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -723,15 +723,6 @@ struct regmap *__regmap_init(struct device *dev,
> } else {
> if ((bus && bus->fast_io) ||
> config->fast_io) {
> - /*
> - * fast_io is incompatible with REGCACHE_RBTREE and REGCACHE_MAPLE
> - * since both need to dynamically allocate memory.
> - */
> - if (config->cache_type == REGCACHE_RBTREE ||
> - config->cache_type == REGCACHE_MAPLE) {
> - ret = -EINVAL;
> - goto err_name;
> - }
> if (config->use_raw_spinlock) {
> raw_spin_lock_init(&map->raw_spinlock);
> map->lock = regmap_lock_raw_spinlock;
>
> ---
> base-commit: b0393e1fe40e962574613a5cdc4a470d6c1de023
> change-id: 20230721-regmap-enable-kmalloc-2e2d0d018cef
>
> Best regards,

\
 
 \ /
  Last update: 2023-07-21 18:41    [W:0.131 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site