Messages in this thread | | | Date | Fri, 21 Jul 2023 09:15:23 +0300 | From | Tony Lindgren <> | Subject | Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative |
| |
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230721 06:00]: > On Fri, Jul 21, 2023 at 08:43:26AM +0300, Tony Lindgren wrote: > > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230720 19:33]: > > > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote: > > > > The controller id cannot be negative. > > > > > > > > > > What does this mean for a changelog? > > > > Just let's fix it while at it and adding port_id in the following patch. > > If you prefer I can squash the change into the fix adding port_id. > > A separate patch like this is fine, just properly document it please :)
OK will do.
Looks like linux-serial not getting added is caused by MAINTAINERS not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This causes get_maintainer.pl to not show linux-serial for a patch touching serial_base_bus.c.. And this will causes git send-email to not pick up linux-serial.. I'll send a patch for MAINTAINERS file too.
Regards,
Tony
| |