lkml.org 
[lkml]   [2023]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
From
On 21/07/2023 17:59, Florian Fainelli wrote:
>>>> + /* Rx VLAN HW Stripping */
>>>> + if (of_property_read_bool(np, "snps,rx-vlan-offload")) {
>>>> + dev_info(&pdev->dev, "RX VLAN HW Stripping\n");
>>>
>>> Why? Drop.
>>>
>>
>> This is an dts option export to dts for user to choose whether or not they
>> Want a Hardware stripping or a software stripping.
>>
>> May I know what is the reason to drop this?
>
> Because the networking stack already exposes knobs for drivers to
> advertise and control VLAN stripping/insertion on RX/TX using ethtool
> and feature bits (NETIF_F_HW_VLAN_CTAG_RX, NETIF_F_HW_VLAN_CTAG_TX).
>
> What you are doing here is encode a policy as a Device Tree property
> rather than describe whether the hardware supports a given feature and
> this is frowned upon.

That's even better reason...

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-07-21 18:28    [W:0.140 / U:25.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site