Messages in this thread | | | Date | Sun, 2 Jul 2023 20:23:21 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 6.4 00/28] 6.4.1-rc1 review - hppa argument list too long |
| |
On 7/2/23 16:30, Linus Torvalds wrote: > On Sun, 2 Jul 2023 at 15:45, Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> >> Would you mind just verifying that yes, that commit on mainline is >> broken for you, and the previous one works? > > Also, while I looked at it again, and still didn't understand why > parisc would be different here, I *did* realize that because parisc > has a stack that grows up, the debug warning I added for GUP won't > trigger. > > So if I got that execve() logic wrong for STACK_GROWSUP (which I > clearly must have), then exactly because it's grows-up, a GUP failure > wouldn't warn about not expanding the stack. > > IOW, would you mind applying something like this on top of the current > kernel, and let me know if it warns? >
I can reproduce the problem in qemu. However, I do not see a warning after applying your patch.
Guenter
| |