Messages in this thread | | | Date | Wed, 19 Jul 2023 16:36:52 +0100 | Subject | Re: [PATCH RFC 4/9] perf jevents: Add sys_events_find_events_table() | From | John Garry <> |
| |
On 19/07/2023 16:25, Ian Rogers wrote: >> I was thinking about this a little further. So you suggest that the >> metric expression contains PMU name per term, like >> "cpu_atom@instructions@ / cpu_atom@cycles@" - how would/could this work >> for PMUs with more complex naming, like the form hisi_siclXXX_cpa_YYY? >> Would we use the "Unit" expression for the metric name, like >> "@hisi_sicl,cpa@event_foo"? > How does this work for events? The "@hisi_sicl,cpa@event_foo" looks > strange, shouldn't it be "hisi_sicl,cpa@event_foo@" but then hisi_sicl > looks like an event name.
Yeah, that was a typo from me - like you say, it would be hisi_sicl,cpa@event_foo@
So is that what you would be suggesting then, such that we specify the PMU in the metric terms? It does look a bit odd :)
> >>>> BTW, which git repo/branch do you guys use for dev? I thought that it >>>> would be acme git, but Namhyung says "We moved to new repos from acme to >>>> perf/perf-tools and perf/perf-tools-next" - where is repo "perf"? >>> Current development is here now: >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next__;!!ACWV5N9M2RV99hQ!OQDHOClSjd6nVZhmgzrK3RwzXuQpP54QhqyIKpITa_MFD4PLdS7yPYSnvInFja9nrFx9Sd-UnlsJ6XUqAh4$ >> Can that be added to the MAINTAINERS file? I suppose it is ok under >> "PERFORMANCE EVENTS SUBSYTEM", since the two would-be git repos listed >> under that same entry would be pretty obvious in purpose. > Arnaldo could you take a look at doing this?
Thanks, John
| |