Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances | Date | Wed, 19 Jul 2023 16:17:07 +0200 |
| |
Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de> > > To prepare for completely separating the VGA console screen_info from > the one used in EFI/sysfb, rename the vgacon instances and make them > local as much as possible. > > ia64 and arm both have confurations with vgacon and efi, but the contents
is this a typo for configurations ?
> never overlaps because ia64 has no EFI framebuffer, and arm only has > vga console on legacy platforms without EFI. Renaming these is required > before the EFI screen_info can be moved into drivers/firmware. > > The ia64 vga console is actually registered in two places from > setup_arch(), but one of them is wrong, so drop the one in pcdp.c and > the fix the one in setup.c to use the correct conditional. >
s/the fix the/fix the
> x86 has to keep them together, as the boot protocol is used to switch > between VGA text console and framebuffer through the screen_info data. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
Patch looks good to me, but I'm not that familiar with some of the arches to give a proper reviewed-by.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |