Messages in this thread | | | Date | Wed, 19 Jul 2023 12:23:42 +0200 | Subject | Re: [PATCH 2/5] arm64: dts: qcom: Add base SM4450 QRD DTS | From | Krzysztof Kozlowski <> |
| |
On 19/07/2023 12:01, Tengfei Fan wrote: > Add DTS for Qualcomm QRD platform which uses SM4450 SoC. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 337abc4ceb17..a0cfd37e674b 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -215,3 +215,4 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
Messed order.
> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts > new file mode 100644 > index 000000000000..851a6761a6ea > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "sm4450.dtsi" > +/ { > + model = "Qualcomm Technologies, Inc. SM4450 QRD"; > + compatible = "qcom,sm4450-qrd", "qcom,sm4450";
Missing bindings.
> + > + aliases { }; > + > + chosen { > + bootargs = " ";
Drop, useless.
OTOH, you miss here several properties. This is not even a basic board - nothing works here, right? Please submit when you have at least serial working.
> + }; > +};
Best regards, Krzysztof
| |