Messages in this thread | | | Date | Wed, 19 Jul 2023 12:13:52 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors |
| |
Hello,
On Wed, Jul 19, 2023 at 09:40:22AM +0200, Thierry Reding wrote: > On Tue, Jul 18, 2023 at 06:57:16PM +0200, Uwe Kleine-König wrote: > > On Tue, Jul 18, 2023 at 03:24:58PM +0200, Thierry Reding wrote: > > > Honestly, do we really need all of this complexity? I have specific > > > configurations to test all of the PWM drivers to make sure they build. > > > There's probably edge cases that don't get tested, but sooner or later I > > > expect some build bot will encounter those and then we can rectify > > > things. But in many cases that I've seen COMPILE_TEST just happens to do > > > more harm than good. > > > > Without COMPILE_TEST you'd need to build at least for the following > > archs to build all pwm drivers: > > > > armv4+5 > > armv7 > > armv7m > > arm64 > > mips > > riscv > > shmobile > > This one is actually ARCH_RENESAS and is armv7.
Oh indeed. ARCH_RENESAS exists for both arm and shmobile. TIL
> > x86 > > But yeah, those are the platforms that I build for. It's not terribly > complicated to do since all of the above have publicly available cross- > compilers that are easy to install. Also, most of the time I do > incremental builds, so these are quite quick. > > > I personally like COMPILE_TEST as it reduces the number of needed test > > builds to 1 (I think). > > Anyway, I wasn't arguing that we should get rid of COMPILE_TEST > altogether, just that for cases like this it doesn't seem worth the > extra complexity. RZ_MTU3 is an MFD and already || COMPILE_TEST, so > we can easily always enable it.
Ah, I got that wrong then. I can life with this one.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |