lkml.org 
[lkml]   [2023]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] arm64: dts: qcom: sdm630: Add support for modem remoteproc
From
On 19.07.2023 12:45, Krzysztof Kozlowski wrote:
> On 19/07/2023 11:34, Alexey Minnekhanov wrote:
>> Modem subsystem in SDM630/660 is similar to MSM8998 and
>> device tree node for it is based on the one from msm8998.dtsi.
>>
>> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
>> ---
>>
>> V3: Use memory-region property to specify memory regions, instead
>> of using "mba" and "mpss" subnodes.
>>
>> V2 link: https://lore.kernel.org/lkml/20230621175046.61521-3-alexeymin@postmarketos.org/
>>
>> arch/arm64/boot/dts/qcom/sdm630.dtsi | 59 ++++++++++++++++++++++++++++
>> 1 file changed, 59 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> index 2136ded22f7e..797625cf78ac 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> @@ -1032,6 +1032,65 @@ data-pins {
>> };
>> };
>>
>> + remoteproc_mss: remoteproc@4080000 {
>> + compatible = "qcom,sdm660-mss-pil";
>
> Missing bindings so standard comment:
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Best regards,
> Krzysztof
>

Bindings are already in linux-next/master since
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed50ac266f67829d4732c8ca61ef1953c2cc63d0
.

And I did check DTS against bindings, it spat 2 warnings about new
remoteproc node, which do not make much sense to me:

DTC_CHK arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb
.../arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb:
remoteproc@4080000: qcom,halt-regs:0: [43] is too short
From schema:
.../Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
.../arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb:
remoteproc@4080000: memory-region: [[45], [46]] is too short
From schema:
.../Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml

because I do not understand where the limitation to number of items for
"qcom,halt-regs" or "memory-regions" come from.

--
Regards,
Alexey Minnekhanov
postmarketOS developer

\
 
 \ /
  Last update: 2023-07-19 12:11    [W:0.054 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site