Messages in this thread | | | Date | Wed, 19 Jul 2023 10:13:27 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device |
| |
Hi Daniel,
daniel@makrotopia.org wrote on Tue, 18 Jul 2023 16:29:07 +0100:
> On Tue, Jul 18, 2023 at 03:55:56PM +0100, Srinivas Kandagatla wrote: > > HI Daniel, > > > > On 18/07/2023 14:55, Daniel Golle wrote: > > > Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not > > > having any cells in order to make sure sysfs attributes of a previously > > > registered NVMEM device are not accidentally reused for a follow-up > > > device which doesn't have any cells. > > > > > > Fixes: 757f8b3835c9 ("nvmem: core: Expose cells through sysfs") > > > > These patches are dropped out of nvmem next branch as it was breaking some > > existing users. > > Ok. I've encountered those commits in linux-next and can confirm that > they were definitely also breaking things here, hence my patches at > least partially fixing that. > > I agree that reverting them for now and reworking them seems to be the > better option in this case, hence my patches won't be needed as such.
Quite the opposite, on my setup I don't have any breakage but as you already fixed the cell name issue (also reported by Chen-yu), if you agree, I will include these fixes (or an improved version) in my next proposal.
Thanks, Miquèl
| |