Messages in this thread | | | Date | Wed, 19 Jul 2023 09:15:51 +0200 | Subject | Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188 | From | AngeloGioacchino Del Regno <> |
| |
Il 18/07/23 13:09, Jason-ch Chen ha scritto: > From: jason-ch chen <Jason-ch.Chen@mediatek.com> > > The reason for changing the patch was that while MT8188 uses the same > pwrap as MT8195, the original code was only applicable to 'compatible = > "mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that > '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too > long', it is necessary to modify the code. > > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
The original binding allowed only "mediatek,mt8188-pwrap", while we need to specify
compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";
for this node, as MT8188's PWRAP is fully compatible with MT8195 as it is the very same IP, hence:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Regards, Angelo
> --- > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > index a06ac2177444..4737e5f45d54 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > @@ -41,7 +41,6 @@ properties: > - mediatek,mt8173-pwrap > - mediatek,mt8183-pwrap > - mediatek,mt8186-pwrap > - - mediatek,mt8188-pwrap > - mediatek,mt8195-pwrap > - mediatek,mt8365-pwrap > - mediatek,mt8516-pwrap > @@ -50,6 +49,11 @@ properties: > - mediatek,mt8186-pwrap > - mediatek,mt8195-pwrap > - const: syscon > + - items: > + - enum: > + - mediatek,mt8188-pwrap > + - const: mediatek,mt8195-pwrap > + - const: syscon > > reg: > minItems: 1
| |