lkml.org 
[lkml]   [2023]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the cifs tree
On Thu, 20 Jul 2023 11:00:21 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
>
> On Wed, 19 Jul 2023 19:47:42 -0500 Steve French <smfrench@gmail.com>
> wrote:
> >
> > Winston had an updated version of the patch - just replaced it with
> > his updated one which does a cast to (char *)
> >
> > ses->local_nls = load_nls((char
> > *)ctx->local_nls->charset);
> >
> > But as he noted in an earlier email thread:
> > > Perhaps I should make a change to load_nls() to take a const char
> > > * instead of char *? If this make sense, I'll do it soon.
> >
> > which is probably cleaner
>
> s/probably/definitely/ ;-)
>

haha yes!

I'll make a small patch for this in the next cycle.

--
Thanks,
Winston

\
 
 \ /
  Last update: 2023-07-20 03:34    [W:0.049 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site