Messages in this thread | | | Date | Wed, 19 Jul 2023 08:55:53 +0200 | From | Nam Cao <> | Subject | Re: [PATCH v2] staging: r8712: Fix memory leak in _r8712_init_xmit_priv() |
| |
On Fri, Jul 14, 2023 at 12:54:17PM -0500, Larry Finger wrote: > In the above mentioned routine, memory is allocated in several places. > If the first succeeds and a later one fails, the routine will leak memory. > This patch fixes commit 2865d42c78a9 ("staging: r8712u: Add the new driver > to the mainline kernel"). A potential memory leak in > r8712_xmit_resource_alloc() is also addressed. > > Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel") > Reported-by: syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/x/log.txt?x=11ac3fa0a80000 > Cc: stable@vger.kernel.org > Cc: Nam Cao <namcaov@gmail.com> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
I am not qualified to make comments on the code style, but it looks functionally correct to me. So:
Reviewed-by: Nam Cao <namcaov@gmail.com>
Best regards, Nam
| |