lkml.org 
[lkml]   [2023]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 3/8] selftests/nolibc: select_null: fix up for big endian powerpc64
Date
Hi, Willy

> Hi Zhangjin,
>
> On Wed, Jul 19, 2023 at 07:56:37AM +0800, Zhangjin Wu wrote:
> > It made me recalled I have at last disabled (not enabled for tinyconfig) the following options:
> >
> > CONFIG_ALTIVEC
> > CONFIG_VSX --> This option enables kernel support for the Vector Scaler extensions
> >
> > Or we can disable the vsx instructions explicitly:
> >
> > -mno-vsx
> >
> > Both of them work well, but I prefer -mno-vsx for to get a faster build, what about you?
> >
> > +CFLAGS_powerpc64 = -m64 -mbig-endian -Wl,-EB,-melf64ppc -mno-vsx
> > +CFLAGS_powerpc64le = -m64 -mlittle-endian -Wl,-EL,-melf64ppc -mno-vsx
> >
> > So, this patch itself is wrong, let's drop it from the next revision.
>
> Better explicitly disable it in the CFLAGS (2nd option) if we want to
> make sure we don't want to rely on this, at least for portability
> purposes.

Ok, thanks, have updated CFLAGS in these two patches locally:

[PATCH v1 7/8] selftests/nolibc: add test support for powerpc64le
[PATCH v1 8/8] selftests/nolibc: add test support for powerpc64

what about the other ones? I'm ready to send v2 ;-)

Best regards,
Zhangjin

>
> Willy

\
 
 \ /
  Last update: 2023-07-19 08:50    [W:0.086 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site