Messages in this thread | | | Date | Wed, 19 Jul 2023 20:21:12 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 3/4] gpio: sifive: Get the parent IRQ's domain from its irq_data |
| |
On Wed, Jul 19, 2023 at 12:03:46PM -0500, Samuel Holland wrote: > On 2023-07-19 11:54 AM, Andy Shevchenko wrote: > > On Wed, Jul 19, 2023 at 09:34:44AM -0700, Samuel Holland wrote:
...
> > Also, can irq_get_irq_data() return NULL? Needs a comment on top > > of that assignment or an additional check. > > No, the earlier loop already verified the IRQ number was valid. I don't think it > can later become invalid. In any case, we already dereference the result of > irq_get_irq_data(irq_number[foo]) in sifive_gpio_child_to_parent_hwirq().
Thanks for explanation, just add a comment.
-- With Best Regards, Andy Shevchenko
| |