lkml.org 
[lkml]   [2023]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 00/14] media: rkisp1: Add support for i.MX8MP
From
Hi Paul,

On 18/11/2022 10:39, Paul Elder wrote:
> This series depends on v3 of "dt-bindings: media: Add macros for video
> interface bus types" [1].
>
> This series extends the rkisp1 driver to support the ISP found in the
> NXP i.MX8MP SoC.
>
> The ISP IP cores in the Rockchip RK3399 (known as the "Rockchip ISP1")
> and in the NXP i.MX8MP have the same origin, and have slightly diverged
> over time as they are now independently developed (afaik) by Rockchip
> and VeriSilicon. The latter is marketed under the name "ISP8000Nano",
> and is close enough to the RK3399 ISP that it can easily be supported by
> the same driver.
>
> The last two patches add support for UYVY output format, which can be
> implemented on the ISP version in the i.MX8MP but not in the one in the
> RK3399.
>
> This version of the series specifically has been tested on a Polyhex
> Debix model A with an imx219 (Raspberry Pi cam v2).

There were comments for the first few patches, but I haven't seen a v4.

I'm marking this series as 'Changes Requested' in patchwork, just so you
know.

Regards,

Hans

>
> [1] https://lore.kernel.org/linux-media/20220615221410.27459-2-laurent.pinchart@ideasonboard.com/
>
> Laurent Pinchart (3):
> dt-bindings: media: rkisp1: Add i.MX8MP ISP example
> media: rkisp1: Add and use rkisp1_has_feature() macro
> media: rkisp1: Configure gasket on i.MX8MP
>
> Paul Elder (11):
> dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible
> media: rkisp1: Add match data for i.MX8MP ISP
> media: rkisp1: Add and set registers for crop for i.MX8MP
> media: rkisp1: Add and set registers for output size config on i.MX8MP
> media: rkisp1: Add i.MX8MP-specific registers for MI and resizer
> media: rkisp1: Shift DMA buffer addresses on i.MX8MP
> media: rkisp1: Add register definitions for the test pattern generator
> media: rkisp1: Fix RSZ_CTRL bits for i.MX8MP
> media: rkisp1: Support devices without self path
> media: rkisp1: Add YC swap capability
> media: rkisp1: Add UYVY as an output format
>
> .../bindings/media/rockchip-isp1.yaml | 79 ++++++++++-
> .../platform/rockchip/rkisp1/rkisp1-capture.c | 102 +++++++++++---
> .../platform/rockchip/rkisp1/rkisp1-common.h | 32 +++++
> .../platform/rockchip/rkisp1/rkisp1-debug.c | 14 +-
> .../platform/rockchip/rkisp1/rkisp1-dev.c | 67 +++++++--
> .../platform/rockchip/rkisp1/rkisp1-isp.c | 128 +++++++++++++++++-
> .../platform/rockchip/rkisp1/rkisp1-regs.h | 90 ++++++++++++
> .../platform/rockchip/rkisp1/rkisp1-resizer.c | 35 ++++-
> include/uapi/linux/rkisp1-config.h | 2 +
> 9 files changed, 509 insertions(+), 40 deletions(-)
>

\
 
 \ /
  Last update: 2023-07-18 10:32    [W:0.265 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site