Messages in this thread | | | From | Ping-Ke Shih <> | Subject | RE: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set() | Date | Mon, 17 Jul 2023 01:28:39 +0000 |
| |
> -----Original Message----- > From: Zhang Shurong <zhang_shurong@foxmail.com> > Sent: Saturday, July 15, 2023 9:43 PM > To: Ping-Ke Shih <pkshih@realtek.com>; Markus.Elfring@web.de; kuba@kernel.org > Cc: kvalo@kernel.org; linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Zhang Shurong > <zhang_shurong@foxmail.com> > Subject: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set() > > If there is a failure during kstrtobool_from_user() > rtw89_debug_priv_btc_manual_set should return a negative error code > instead of returning the count directly. > > Fix this bug by returning an error code instead of a count after > a failed call of the function "kstrtobool_from_user". Moreover > I omitted the label "out" with this source code correction. > > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> --- > Changes in v2: > - Corrected the format of this patch > - Used variable ret instead of goto out > Changes in v3: > - Improved change description > Changes in v4: > - Improved change description >
Normally, we preserve three '-' as delimiter here. I tried to use pwclient to apply this patch, and fortunately it works. So, I think no need to resend because of this.
[...]
| |