Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 16 Jul 2023 09:41:56 +0200 | Subject | Re: [PATCH v2 1/1] gpio: mmio: handle "ngpios" properly in bgpio_init() |
| |
On Tue, Jul 11, 2023 at 5:13 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
> bgpio_init() uses "sz" argument to populate ngpio, which is not > accurate. Instead, read the "ngpios" property from the DT and if it > doesn't exist, use the "sz" argument. With this change, drivers no > longer need to overwrite the ngpio variable after calling bgpio_init(). > > If the "ngpios" property is specified, bgpio_bits is calculated > as the round up value of ngpio. At the moment, the only requirement > specified is that the round up value must be a multiple of 8 but > it should also be a power of 2 because we provide accessors based > on the bank size in bgpio_setup_accessors(). > > Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Still looks good! :)
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |