lkml.org 
[lkml]   [2023]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rust: init: Implement Zeroable::zeroed()
> By analogy to Default::default(), this just returns the zeroed
> representation of the type directly. init::zeroed() is the version that
> returns an initializer.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
> rust/kernel/init.rs | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
> index b4332a4ec1f4..c300ce39ac10 100644
> --- a/rust/kernel/init.rs
> +++ b/rust/kernel/init.rs
> @@ -1354,7 +1354,14 @@ pub unsafe trait PinnedDrop: __internal::HasPinData {
> /// ```rust,ignore
> /// let val: Self = unsafe { core::mem::zeroed() };
> /// ```
> -pub unsafe trait Zeroable {}
> +pub unsafe trait Zeroable: core::marker::Sized {

Note that `Sized` is in the prelude so you do not need the full path
`core::marker::`. Also same concern as Alice.

> + /// Create a new zeroed T.
> + ///
> + /// Directly returns a zeroed T, analogous to Default::default().

Please add a link to `init::zeroed()` and explain that that is the
initializer version of this function.

> + fn zeroed() -> Self {
> + unsafe { core::mem::zeroed() }

Missing `SAFETY` comment.

--
Cheers,
Benno

> + }
> +}
>
> /// Create a new zeroed T.
> ///
>
> ---
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
> change-id: 20230714-zeroed-dd05bc737f85
>
> Thank you,
> ~~ Lina
>

\
 
 \ /
  Last update: 2023-07-16 20:52    [W:1.678 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site