Messages in this thread | | | Date | Sat, 15 Jul 2023 10:11:46 -0500 | Subject | Re: [PATCH] net: Explicitly include correct DT includes | From | Alex Elder <> |
| |
On 7/14/23 12:48 PM, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org>
(I significantly reduced the addressee list to permit the message to be sent.)
For "drivers/net/ipa/ipa_main.c":
Acked-by: Alex Elder <elder@linaro.org>
> --- > drivers/net/can/bxcan.c | 1 - > drivers/net/can/ifi_canfd/ifi_canfd.c | 1 - . . . > drivers/net/ieee802154/ca8210.c | 1 - > drivers/net/ipa/ipa_main.c | 2 +- > drivers/net/pcs/pcs-rzn1-miic.c | 1 + > drivers/net/phy/marvell-88x2222.c | 1 - > drivers/net/phy/mediatek-ge-soc.c | 2 -- > drivers/net/wireless/ath/ath10k/ahb.c | 2 +- > drivers/net/wireless/ath/ath11k/qmi.c | 1 - > drivers/net/wireless/ath/wcn36xx/main.c | 3 +-- > drivers/net/wireless/intersil/orinoco/airport.c | 2 +- > drivers/net/wireless/mediatek/mt76/mt7915/soc.c | 1 - > drivers/net/wireless/silabs/wfx/bus_sdio.c | 2 +- > net/core/of_net.c | 1 + > 124 files changed, 110 insertions(+), 120 deletions(-)
. . .
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index 6a2f2fc2f501..da853353a5c7 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -13,8 +13,8 @@ > #include <linux/firmware.h> > #include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_device.h> > #include <linux/of_address.h> > +#include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/firmware/qcom/qcom_scm.h> > #include <linux/soc/qcom/mdt_loader.h>
. . .
| |