Messages in this thread | | | Date | Sat, 15 Jul 2023 09:42:01 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] tracing: Add free_trace_iter_content() helper function |
| |
On Sat, 15 Jul 2023 13:15:32 +0800 Zheng Yejian <zhengyejian1@huawei.com> wrote:
> > @@ -6709,7 +6723,12 @@ static int tracing_open_pipe(struct inode *inode, struct file *filp) > > } > > > > trace_seq_init(&iter->seq); > > - iter->trace = tr->current_trace; > > + > > + iter->trace = kzalloc(sizeof(*iter->trace), GFP_KERNEL); > > + if (!iter->trace) > > + goto fail; > > Hi, Steve, 'ret' may need to be set before `goto fail`: > ret = -ENOMEM; >
As I mentioned to Masami, this hunk of the patch didn't belong. Something got mixed up in the commit. This patch even depends on the previous patch to remove the allocation completely.
-- Steve
| |