lkml.org 
[lkml]   [2023]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/2 net-next] net: phy: mscc: add support for CLKOUT ctrl reg for VSC8531 and similar
    On Thu, Jul 13, 2023 at 11:35 PM Andrew Lunn <andrew@lunn.ch> wrote:
    >
    > > +set_reg:
    > > + mutex_lock(&phydev->lock);
    > > + rc = phy_modify_paged(phydev, MSCC_PHY_PAGE_EXTENDED_GPIO,
    > > + VSC8531_CLKOUT_CNTL, mask, set);
    > > + mutex_unlock(&phydev->lock);
    >
    > What is this mutex protecting?

    This was inspired by vsc85xx_edge_rate_cntl_set().
    Which has the same format.

    I'll re-test with this lock removed.
    I may be misremembering (or maybe I did something silly at some
    point), but there was a weird stack-trace warning before adding this
    lock there.
    This was with a 5.10.116 kernel version.

    >
    > Andrew

    \
     
     \ /
      Last update: 2023-07-16 20:47    [W:4.905 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site