lkml.org 
[lkml]   [2023]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH Control documentation
Guenter Roeck <linux@roeck-us.net> 於 2023年7月14日 週五 下午5:59寫道:
>
> On 7/14/23 00:13, Krzysztof Kozlowski wrote:
> > On 14/07/2023 09:04, 蔡承達 wrote:
> >
> >> > This is because our register layout for PWM and Tach is not
> >> continuous.
> >>
> >> > PWM0 used 0x0 0x4, Tach0 used 0x8 0xc
> >>
> >> > PWM1 used 0x10 0x14, Tach1 used 0x18 0x1c
> >>
> >> > ...
> >>
> >> > Each PWM/Tach instance has its own controller register and is not
> >> dependent on others.
> >
> > Your email reply quoting style is very difficult to read.
> >
> >>
> >>
> >>
> >> Hi Guenter,
> >>
> >>
> >>
> >> Did you receive a response to my previous email?
> >>
> >> I would like to inquire if you have any further concerns regarding the PWM
> >> and Tach with 16 instances.
> >
> > But isn't like this in all PWMs in all SoCs?
> >
>
> Correct, pretty much every fan controller is implemented that way.
> I don't understand the logic.
>

Hi Krzysztof and Guenter,

Apologies for any confusion earlier.
So, you think that the implementation with 16 instances of TACH/PWM
device nodes in dts instead of one is ok to you, right?

Thanks

Best regards,
Billy Tsai

\
 
 \ /
  Last update: 2023-07-16 20:48    [W:0.078 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site