Messages in this thread | | | Date | Fri, 14 Jul 2023 12:50:16 +0800 | Subject | Re: [PATCH] erofs: deprecate superblock checksum feature | From | Jingbo Xu <> |
| |
On 7/14/23 12:29 PM, Gao Xiang wrote: > > > On 2023/7/14 11:38, Jingbo Xu wrote: >> Later we're going to introduce fs-verity based verification for the >> whole image. Make the superblock checksum feature deprecated. > > I'd suggest that > > > "Later we're going to try the self-contained image verification. > The current superblock checksum feature has quite limited > functionality, instead, merkle trees can provide better protection > for image integrity. > > Since the superblock checksum is a compatible feature, just > deprecate now. " >
Yeah, another concern is that xxhash is used in the following xattr name filter feature [1] which is on the way. It may be redundant to use two hashing algorithms for one filesystem.
[1] https://lore.kernel.org/all/20230714031034.53210-1-jefflexu@linux.alibaba.com/
-- Thanks, Jingbo
| |