lkml.org 
[lkml]   [2023]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
    Date
    The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
    fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
    not set it.

    Flags should signal differences from the default values. After cleaning
    up all occurrences of FBINFO_DEFAULT, the token will be removed.

    v2:
    * fix commit message (Miguel)

    Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
    Acked-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    Cc: Teddy Wang <teddy.wang@siliconmotion.com>
    ---
    drivers/staging/fbtft/fbtft-core.c | 2 +-
    drivers/staging/sm750fb/sm750.c | 1 -
    2 files changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
    index 3a4abf3bae40..eac1d570f437 100644
    --- a/drivers/staging/fbtft/fbtft-core.c
    +++ b/drivers/staging/fbtft/fbtft-core.c
    @@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
    info->var.transp.offset = 0;
    info->var.transp.length = 0;

    - info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
    + info->flags = FBINFO_VIRTFB;

    par = info->par;
    par->info = info;
    diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
    index c260f73cf570..79bcd5bd4938 100644
    --- a/drivers/staging/sm750fb/sm750.c
    +++ b/drivers/staging/sm750fb/sm750.c
    @@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
    info->screen_base = crtc->v_screen;
    pr_debug("screen_base vaddr = %p\n", info->screen_base);
    info->screen_size = line_length * var->yres_virtual;
    - info->flags = FBINFO_FLAG_DEFAULT | 0;

    /* set info->fix */
    fix->type = FB_TYPE_PACKED_PIXELS;
    --
    2.41.0
    \
     
     \ /
      Last update: 2023-07-16 20:47    [W:3.280 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site