Messages in this thread | | | From | Jesper Dangaard Brouer <> | Date | Fri, 14 Jul 2023 09:43:04 +0200 | Subject | Re: [PATCH net-next] net: mana: Add page pool for RX buffers |
| |
On 14/07/2023 05.53, Jakub Kicinski wrote: > On Thu, 13 Jul 2023 14:48:45 +0000 Haiyang Zhang wrote: >> Add page pool for RX buffers for faster buffer cycle and reduce CPU >> usage. >> >> Get an extra ref count of a page after allocation, so after upper >> layers put the page, it's still referenced by the pool. We can reuse >> it as RX buffer without alloc a new page. > > Please use the real page_pool API from include/net/page_pool.h > We've moved past every driver reinventing the wheel, sorry.
+1
Quoting[1]: Documentation/networking/page_pool.rst
Basic use involves replacing alloc_pages() calls with the page_pool_alloc_pages() call. Drivers should use page_pool_dev_alloc_pages() replacing dev_alloc_pages().
[1] https://kernel.org/doc/html/latest/networking/page_pool.html
| |