lkml.org 
[lkml]   [2023]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5] wifi: ath5k: remove phydir check from ath5k_debug_init_device()
From
On 14. 07. 23, 9:10, Minjie Du wrote:
> 'phydir' returned from debugfs_create_dir() is checked against NULL.
> As the debugfs API returns an error pointer,
> the returned value can never be NULL.
>
> Therefore, as the documentation suggests that the check is unnecessary
> and other debugfs calls have no operation in error cases,
> it is advisable to completely eliminate the check.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2023-07-16 20:47    [W:0.063 / U:1.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site