lkml.org 
[lkml]   [2023]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] regulator: max77857: Add ADI MAX77857/59/MAX77831 Regulator Support
On Tue, Jul 11, 2023 at 07:27:48PM +0300, Okan Sahin wrote:

> Regulator driver for MAX77857/59 and MAX77831.
> The MAX77857 is a high-efficiency, high-performance
> buck-boost converter targeted for systems requiring
> a wide input voltage range (2.5V to 16V).

This looks good, I've queued it for CI (it'll probably be Monday before
I check that though). One minor nit:

> +struct regmap_config max77857_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .cache_type = REGCACHE_RBTREE,
> + .volatile_reg = max77857_volatile_reg,
> +};

Please prefer REGCACHE_MAPLE for new devices, it probably makes no
practical difference but it's more modern code and we might want to
retire _RBTREE at some point - please send an incremental patch to
update assuming this makes it through CI OK (I'd expect it to).
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-16 20:52    [W:0.071 / U:23.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site