Messages in this thread | | | From | Anup Sharma <> | Date | Sat, 15 Jul 2023 03:06:09 +0530 | Subject | Re: [PATCH v3 0/6] Add support for Firefox's gecko profile format |
| |
On Tue, Jul 11, 2023 at 04:38:06AM +0530, Anup Sharma wrote: > This patch series adds support for Firefox's gecko profile format. > The format is documented here [1]. > > I have incorporated several changes based on feedback from the > previous version of the patch. However, there are still a few > remaining comments that I am currently addressing. > > Additionally, I am still in the process of learning how to send > patches in a series, so there may be some shortcomings in this > particular series as well. > > changes from v2: > - renamed mod to func > - removed unnessecary imports print_function > - removed shebang python env declaration > - changed _createtread to _createThread > - Commits in better order.
Hello everyone, I wanted to express my gratitude for your support. I recently received an email from GSoC admin informing me that I have successfully passed my midterm evaluation. I am thrilled about this news!. Ian, could you please provide some insights on the commit arrangement in v3 compared to v2? I noticed in v3, on 1/6 you have mentioned regarding the commit arrangement. I want to make sure I haven't overlooked. Currently, I'm focusing on developing the next version of patches, so having this information would be extremely beneficial to me. Thank you in advance!
> [1] https://github.com/firefox-devtools/profiler/blob/main/docs-developer/gecko-profile-format.md > > Anup Sharma (6): > scripts: python: Add initial script file with imports. > scripts: python: Extact necessary information from process event > scripts: python: thread sample processing to create thread with > schemas > scripts: python: Add trace end processing and JSON output > scripts: python: Implement add sample function and return finish > scripts: python: implement get or create frame and stack function > > .../scripts/python/firefox-gecko-converter.py | 221 ++++++++++++++++++ > 1 file changed, 221 insertions(+) > create mode 100644 tools/perf/scripts/python/firefox-gecko-converter.py > > -- > 2.34.1 >
| |