lkml.org 
[lkml]   [2023]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4 3/4] dt-bindings: qcom-qce: add SoC compatible string for ipq9574
From


On 6/23/2023 6:23 PM, Krzysztof Kozlowski wrote:
> On 23/06/2023 13:55, Anusha Rao wrote:
>>> Document the compatible string for ipq9574.
>>>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>>> ---
>>> Changes in V4:
>>> - Picked up Reviewed-by tag.
>> A gentle reminder to pick the dt-binding patch.
>> As the dts change is picked, this patch is required to resolve dt-bindings check issues.
> One patchset with four patches targeting three different subsystems, so
> no wonder it gets missed. You will usually receive better results with
> splitting such patchsets per subsystems.
>
> One more thing is lack of proper subject prefix which indicates the
> subsystem. Without it why anyone would pick it up? For example me, I
> would just ignore it for my subsystem...
Ok..Referred previous commit titles of this file and added subject
prefix. Do you suggest to repost it with
"dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574" ?

Thanks,
Anusha
>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2023-07-12 08:34    [W:0.050 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site