Messages in this thread | | | Date | Mon, 10 Jul 2023 17:22:28 +0200 | Subject | Re: [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers | From | Thomas Zimmermann <> |
| |
Hi
Am 10.07.23 um 16:24 schrieb Miguel Ojeda: > On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: >> >> The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct >> fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do >> not set it. > > `framebuffer_alloc()` does indeed use `kzalloc()`, but the docs do not > mention the zeroing. Should that guarantee be documented?
I'll append a patch to the series that documents this.
> >> Flags should signal differences from the default values. After cleaning >> up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. > > occurences -> occurrences > > can -> will maybe? Since the intention of the patch series is to > remove it (them) altogether).
Sure.
Best regards Thomas
> > Thanks! > > Cheers, > Miguel
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) [unhandled content-type:application/pgp-signature] | |