Messages in this thread | | | Date | Mon, 10 Jul 2023 19:24:56 +0530 | Subject | Re: [PATCH 5/6] arm64: dts: qcom: ipq5332: Add thermal zone nodes | From | Praveenkumar I <> |
| |
On 7/10/2023 7:04 PM, Praveenkumar I wrote: > > On 7/10/2023 5:44 PM, Konrad Dybcio wrote: >> On 10.07.2023 13:23, Dmitry Baryshkov wrote: >>> On 10/07/2023 13:37, Praveenkumar I wrote: >>>> This patch adds thermal zone nodes for sensors present in >>>> IPQ5332. >>>> >>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 72 >>>> +++++++++++++++++++++++++++ >>>> 1 file changed, 72 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>>> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>>> index a1e3527178c0..8b276aeca53e 100644 >>>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>>> @@ -527,4 +527,76 @@ timer { >>>> <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | >>>> IRQ_TYPE_LEVEL_LOW)>, >>>> <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | >>>> IRQ_TYPE_LEVEL_LOW)>; >>>> }; >>>> + >>>> + thermal-zones { >>>> + rfa-0-thermal{ >> thermal { > In all other DTS, name is 'thermal-zones". Hence followed the same. Sorry, understood now. Will give space after "rfa-0-thermal" >> >>>> + polling-delay-passive = <0>; >>>> + polling-delay = <0>; >>>> + thermal-sensors = <&tsens 11>; >>>> + >>>> + trips { >> Indentation seems off, tab size for kernel code is 8 spaces. > Sure, will check the indent and update in next patch. >> >> Konrad >>>> + rfa-0-critical { >>>> + temperature = <125000>; >>>> + hysteresis = <1000>; >>>> + type = "critical"; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> + rfa-1-thermal { >>>> + polling-delay-passive = <0>; >>>> + polling-delay = <0>; >>>> + thermal-sensors = <&tsens 12>; >>>> + >>>> + trips { >>>> + rfa-1-critical { >>>> + temperature = <125000>; >>>> + hysteresis = <1000>; >>>> + type = "critical"; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> + misc-thermal { >>>> + polling-delay-passive = <0>; >>>> + polling-delay = <0>; >>>> + thermal-sensors = <&tsens 13>; >>>> + >>>> + trips { >>>> + misc-critical { >>>> + temperature = <125000>; >>>> + hysteresis = <1000>; >>>> + type = "critical"; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> + cpu-top-thermal { >>>> + polling-delay-passive = <0>; >>>> + polling-delay = <0>; >>>> + thermal-sensors = <&tsens 14>; >>>> + >>>> + trips { >>>> + cpu-top-critical { >>>> + temperature = <125000>; >>>> + hysteresis = <1000>; >>>> + type = "critical"; >>>> + }; >>>> + }; >>> Could you please add a passive cooling devices for the CPU? >>> >>>> + }; >>>> + >>>> + top-glue-thermal { >>>> + polling-delay-passive = <0>; >>>> + polling-delay = <0>; >>>> + thermal-sensors = <&tsens 15>; >>>> + >>>> + trips { >>>> + top-glue-critical { >>>> + temperature = <125000>; >>>> + hysteresis = <1000>; >>>> + type = "critical"; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> }; > -- > Thanks, > Praveenkumar
| |