lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: tegra-kbc - use devm_platform_ioremap_resource
On Sun, Jul 09, 2023 at 03:41:08PM +0200, Martin Kaiser wrote:
> devm_platform_get_and_ioremap_resource maps a resource and returns its
> physical address. If we don't need the physical address, we should call
> devm_platform_ioremap_resource instead.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Different variations of these have been going around for a while now. I
don't really see much use in these tiny conversions.

But the patch also isn't wrong, so while I'm at it:

Acked-by: Thierry Reding <treding@nvidia.com>


>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index d5a6c7d8eb25..c9a823ea45d0 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -640,7 +640,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
>
> timer_setup(&kbc->timer, tegra_kbc_keypress_timer, 0);
>
> - kbc->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> + kbc->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(kbc->mmio))
> return PTR_ERR(kbc->mmio);
>
> --
> 2.30.2
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-10 15:12    [W:0.032 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site