Messages in this thread | | | Date | Mon, 10 Jul 2023 12:19:32 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH blktests v1 2/3] nvme/rc: Avoid triggering host nvme-cli autoconnect |
| |
On Mon, Jul 10, 2023 at 12:53:17PM +0300, Max Gurtovoy wrote: > > Agree on setting the hard coded values for hostnqn and hostid instead of > > > reading the /etc/nvme/* files. This should do the work IMO, isn't it ? > > > > Do you mean that nvme-cli will ignore the udev trigger when a different hostnqn > > is invovled? At least for the well-known discover controller the hostqnq > > doesn't work. Though not sure if I understood you correctly here. > > All I was saying is that your issue would have been fixed easily by 2-3 LOC > by removing the usage of /etc/nvme/* files that are usually configured by > system administrator and use a default values for blktests hostnqn and > hostid.
Okay.
> The usage of --context in blktests is redundant IMO.
Right, I made a bit of a mess with the commit message. Sorry about that.
| |