| Date | Mon, 10 Jul 2023 11:06:54 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v5 06/20] x86/decompressor: Store boot_params pointer in callee save register |
| |
On Wed, Jun 07, 2023 at 09:23:28AM +0200, Ard Biesheuvel wrote: > Instead of pushing and popping %RSI several times to preserve the struct > boot_params pointer across the execution of the startup code, move it > into a callee save register before the first call into C, and copy it > back when needed. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > arch/x86/boot/compressed/head_64.S | 34 +++++++------------- > 1 file changed, 11 insertions(+), 23 deletions(-)
I like that.
We do a similar dance in arch/x86/kernel/head_64.S. Care to fix that too, in a separate patch?
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|